Deprecate all iOS and Android precheck actions #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
reviewed
Jul 30, 2024
| end | ||
|
|
||
| def self.deprecated_notes | ||
| 'This action is deprecated and will be removed in an upcoming Release Toolkit version. Any necessary steps that are included in this precheck action should be added directly in a repo\'s Fastfile. See https://github.com/wordpress-mobile/release-toolkit/issues/576' |
There was a problem hiding this comment.
Nitpick.
Suggested change
| 'This action is deprecated and will be removed in an upcoming Release Toolkit version. Any necessary steps that are included in this precheck action should be added directly in a repo\'s Fastfile. See https://github.com/wordpress-mobile/release-toolkit/issues/576' | |
| 'This action is deprecated and will be removed in the next major version Release Toolkit update. Any necessary steps that are included in this precheck action should be added directly in a repo\'s Fastfile. See https://github.com/wordpress-mobile/release-toolkit/issues/576' |
There was a problem hiding this comment.
Changed in a27ec90
mokagio
approved these changes
Jul 30, 2024
| def self.description | ||
| 'Runs some prechecks before preparing for a new test build' | ||
| '(DEPRECATED) Runs some prechecks before preparing for a new test build' |
There was a problem hiding this comment.
Appreciate the effort here, but FWIW I wouldn't consider it necessary. Fastlane already prints the deprecation alert when the lane is called and in the docs:
There was a problem hiding this comment.
Good point. Removed in 8d87d87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes #576
This PR deprecates the following precheck actions:
android_betabuild_prechecksandroid_build_prechecksandroid_codefreeze_prechecksandroid_completecodefreeze_prechecksandroid_finalize_prechecksandroid_hotfix_prechecksios_betabuild_prechecksios_build_prechecksios_codefreeze_prechecksios_completecodefreeze_prechecksios_finalize_prechecksios_hotfix_prechecksWhen the versioning changes were added in #512, it was decided that we would stop using these
-prechecksactions and instead use any necessary steps from those actions directly in Fastfiles. The idea is that the precheck actions were opaque and made it harder to figure out where errors were occuring when running release management lanes. There are some other versioning and preflight actions that we'll want to deprecate as well (at least the versioning ones for sure), but I decided to limit this PR to only the precheck actions.Example: See these WooCommerce iOS and Android PRs that switched from using the precheck actions to directly adding the steps in the Woo lanes:
From what I can tell, the Simplenote Android, iOS, and Mac apps are the only apps still using these prechecks (they weren't updated with the versioning changes last year), so it won't be a lot of work for us once these actions are eventually removed.
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.